This might need a rewrite of EnsembleAnalysis to directly use a full analysis over a Universe. If so, first raise a separate issue for those changes to the framework and then come back here.

Have you figured out how much work it is going to be to add h-bond analysis?

I looked at the MDAnalysis docs and think it will not be too much work to implement a H-Bond analysis. I want to try making a decorator that runs an AnalysisBase subclass i, It would simply require making a few generic methods for saving the results for each ensemble.

I'll have a draft pull request for EnsembleWrapper up hopefully by tonight. I'm writing it as a decorator for AnalysisBase. It does add a new class, but it's fairly rudimentary, just passing data into the original Analysis.

@cadeduckworth here's the issue for adding H-bond analysis, in case you want to have a go.

Perhaps @ALescoulie could help with reviewing once you get a PR up?

Yes that sounds great! I am reading through the MDAnalysis docs now. There is an 'autocorrelation' module for hydrogen bond calculations that may also be of use.

After playing around with it, it appears that the most useful information can be obtained by specifying the solute of interest as an acceptor for one run, specifying the solute as a donor for another, generating data frames from each of these two (results)arrays, and then concatenating the data frames. So far it seems like this is the quickest way to get information only pertaining to H-bond accepting/donating by the solute. I think there are more complicated alternatives available regarding combined selection methods, and I will continue to experiment. However, using the split acceptor/donor method I explained above results in some overlap of the internal H-bonds, which can possibly be selectively removed when concatenating the two data frames and sorting or grouping. I am going to try out a few more things and then upload the notebook to a private repository so y'all can review the output generated so far. From my examples it seems that it would not take much more work to implement ensemble analysis once we decide the best options for acceptor/donor selections.

You should not need to do two runs. If you define donors and acceptors appropriately then you should only need one run and then you can sort the resulting list of H-bonds appropriately. Generally, we really want to avoid to analyze trajectories too often and rather work with generated data.

Also HydrogenBondAnalysis has the between=[group1, group2] keyword to only look for inter-group H-bonds https://userguide.mdanalysis.org/stable/examples/analysis/hydrogen_bonds/hbonds-selections.html#Hydrogen-bonds-between-specific-groups

See also tutorial in https://userguide.mdanalysis.org/stable/examples/analysis/hydrogen_bonds/hbonds.html

@cadeduckworth
-reminder for myself to create a pull request
EDIT: and add the module I developed some time ago