Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Browser interference with MetaMask validation #1005

Closed
migbash opened this issue Jan 25, 2023 · 0 comments · Fixed by #1012
Closed

Brave Browser interference with MetaMask validation #1005

migbash opened this issue Jan 25, 2023 · 0 comments · Fixed by #1012
Assignees
@migbash

Comments

@migbash
Copy link
Collaborator

migbash commented Jan 25, 2023 •
edited
Loading

NOTES

When using Brave Browser for the platform - the native Brave Wallet (Crypto Wallet) interferes with the isMetaMask validation check as it installs/includes MetaMask by default. Future issues could arise from the use of Brave Browser and another non-MetaMask wallet as MetaMask will be detected by Brave source source-2

✅ Solution
User needs to have the (default) Ethereum Wallet setting set to None for avoiding interference.
(+) added extra validation for MetaMask (Original) extension check
@migbash migbash converted this from a draft issue Jan 25, 2023
@migbash migbash self-assigned this Jan 25, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Jan 25, 2023
@migbash migbash closed this as completed Jan 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Betarena Scores Jan 25, 2023
This was referenced Jan 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@migbash migbash

Labels
None yet
Projects
Betarena Scores
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev to PROD Betarena/scores
1 participant
@migbash