-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename connection to session? #222
Comments
I had these thoughts in the past, and kept Another consideration is that WebTransport does have concept of "Connection", but it also allows multiple "Session"s within the same connection.
It might make sense to be more appropriate and rename what today is called |
I would argue that the relation between the SessionRequest and Connection is incorrectly modeled, as the connection precedes the session request, but the session is not, and is obtained as a result. Thus, even though they overlap, it is wrong. And this is what I find confusing for the new users. Simplest name for the concept - perhaps it is, but this was probably a concern for the WebTransport RFC authors as well, and they decided against mixing the concepts like this; this is why I don't understand why at the library level a judgement or decision on this has to even be considered - so I deduced it must just be an inconsistency created as a result of confusion about the clarity of the concepts of the underlying spec. For what it's worth, if there were separate session and connection types, the public API of what we have implemented now would likely 90% to 100% reside in the session type, while connection would expose something entirely different. So, on the urgency of the matter - if it is indeed an error, then the quicker it is corrected the less of an impact it would have for the future development; fixing the bad model can make wonders to unlock how we think about the code and what ways to evolve it further we see. It is not urgent in the urgency sense, but I'd classify it as a high priority due these concerns. I personally do not need this to be done quick or anything, I just show that there are justifications on why something like this should likely be done sooner than later. I feel like this message went down a bit rude, as it supposes mistakes were made, so I apologize in advance; these are merely logical deductions based on the observations, and I may be wrong. |
Perhaps I made some mistake, but I do NOT see where I expressed that, can you please show me? Instead, quoting my self:
And that indeed expresses the fact that I DO agree on the fact that I only mentioned the reason why (erroneously) I ended up naming
I DO agree on that. Errors need to fixed as soon as possible. What I meant was more something like "it is not a bug" and just a naming convention; "critical" in that sense. Please note: this does NOT mean "won't fix" or "not an issue". |
Great, thanks for making it clearer for me! |
In the WebTransport spec and corresponding terminology the connections is always called session. I suggest altering the
wtransport
type names to accomodate the type names that are closer to the spec.The benefits of this are:
wtransport
internals/specificswtransport
developers for coming up with type names - as they'll be closer to the mental model of WebTransportThe downsides are:
The text was updated successfully, but these errors were encountered: