Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package Submission: BreastSubtypeR #3696

Open
10 tasks done
yqkiuo opened this issue Jan 2, 2025 · 3 comments
Open
10 tasks done

New Package Submission: BreastSubtypeR #3696

yqkiuo opened this issue Jan 2, 2025 · 3 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@yqkiuo
Copy link

yqkiuo commented Jan 2, 2025

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @yqkiuo

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: BreastSubtypeR
Type: Package
Title: Methods for breast cancer intrinsic subtyping
Description: BreastSubtypeR is an R package that provides a collection of methods for intrinsic molecular subtyping of breast cancer. It includes subtyping methods for nearest centroid-based subtyping (NC-based) and single sample predictor (SSP-based), along with tools for integrating clinical data and visualizing results. 
Encoding: UTF-8
Version: 0.99.0
biocViews: RNASeq, Software, GeneExpression, Classification
Authors@R: c(
    person(given = "Qiao", family = "Yang", 
	    role=c("aut", "cre"), email="[email protected]", 
  comment = c(ORCID = "0000-0002-4098-3246")) 
  )
Depends:
    R (>= 4.4.0)
Imports:
    impute (>= 1.80.0),
    magrittr (>= 2.0.3),
    dplyr (>= 1.1.0),
    data.table (>= 1.16.0),
    stringr (>= 1.5.1),
    rlang (>= 1.1.4),
    ComplexHeatmap (>= 2.22.0),
    RColorBrewer (>= 1.1-3),
    circlize (>= 0.4.16),
    bslib (>= 0.8.0),
    ggplot2 (>= 3.5.1),
    ggrepel (>= 0.9.6),
    shiny (>= 1.9.1),
    e1071 (>= 1.7-8),
    methods,
    withr
Suggests:
    knitr,
    rmarkdown
URL: https://github.com/yqkiuo/BreastSubtypeR
BugReports: https://github.com/yqkiuo/BreastSubtypeR/issues
License: GPL (>= 3)
VignetteBuilder: knitr
Roxygen: list(markdown = TRUE)
LazyData: FALSE
RoxygenNote: 7.3.2

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jan 2, 2025
@lshep
Copy link
Contributor

lshep commented Jan 14, 2025

This package currently does not interact with common Bioconductor classes. You mention gene expression and clinical data which would likely mean your package should work with a SummarizedExperiment Object. You can also look at structures like BiocSet or GSEABase for gene sets.

Also Could you please provide an abstract/intro section in your vignette that
provides motivation for inclusion in Bioconductor and when appropriate a review
and comparison to existing Bioconductor packages with similar functionality or
scope.

@lshep lshep added 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Jan 14, 2025
@yqkiuo
Copy link
Author

yqkiuo commented Jan 29, 2025

Hi @lshep,

Thank you so much for your comments. And I made changes to the BreastSubtypeR package as below.

  • Work with a SummarizedExperiment Object.
  • Provide an abstract/a motivation in the vignette.

Best,
Qiao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants