Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limpa #3698

Open
10 tasks done
gksmyth opened this issue Jan 3, 2025 · 6 comments
Open
10 tasks done

limpa #3698

gksmyth opened this issue Jan 3, 2025 · 6 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK

Comments

@gksmyth
Copy link

gksmyth commented Jan 3, 2025

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @gksmyth

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: limpa
Version: 0.99.0
Date: 2025-01-03
Title: Linear Models for Proteomics Data
Description: Quantification and differential analysis of mass-spectrometry proteomics data, with probabilistic recovery of information from missing values. Estimates the detection probability curve (DPC), which relates the probability of successful detection to the underlying expression level of each peptide, and uses it to incorporate peptide missing values into protein quantification and subsequent differential expression analyses. The package produces objects suitable for downstream analysis in limma.
Authors@R: c(person("Mengbo", "Li",
  email = "[email protected]",
  role = "aut",
  comment = c(ORCID = "0000-0002-9666-5810")),
  person("Gordon", "Smyth",
  email = "[email protected]",
  role = c("cre", "aut"),
  comment = c(ORCID = "0000-0001-9221-2892")))
License: GPL (>=2)
Depends: limma
Imports: methods, stats, data.table, statmod
Suggests: knitr, BiocStyle
VignetteBuilder: knitr
biocViews: Bayesian, DataImport, DifferentialExpression, GeneExpression, MassSpectrometry, Preprocessing, Proteomics, Regression, Software

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jan 3, 2025
@lshep
Copy link
Contributor

lshep commented Jan 9, 2025

I am worried about the name of the package and how close to the already existing limpca. I'll look over for other pre-review conditions in the next few days but wanted to mention this while I was thinking of it.

@gksmyth
Copy link
Author

gksmyth commented Jan 10, 2025

We could like to keep the limpa name if at all possible. The name is simple, catchy and emphasises the close relationship with the limma package. The relationship with limma is close, because limpa` starts by reading in precursor-level data from DIA-NN, Spectronaut or MaxQuant and finishes with a limma linear-model object for downstream analysis in limma. The first author, Mengbo Li, has been invited to present a workshop in Boston in a few months with the title:

Workshop Title: "Missingness-informed protein quantification and differential expression analysis powered by limma and limpa"

so you can see how the two package names go together.

I can see that limpca has only one extra letter, but I doubt there will be much confusion in practice. It's a pity that limpca wasn't called lmpca, which to me would have been more natural as well as shorter. All other Bioconductor packages with names starting with "lim" have some connection with limma.

@lshep lshep added the pre-check passed pre-review performed and ready to be added to git label Jan 14, 2025
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Jan 14, 2025
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): limpa_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/limpa to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Jan 14, 2025
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK
Projects
None yet
Development

No branches or pull requests

4 participants