-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Block Type & Containers #23
Comments
As long as you will keep the coding standards we follow (basically the Sylius ones) and support strict PHP types I can accept your PR 🙂 . |
Sounds great, we will do some more work and handle the BDD, strict and code standards and then do a PR when we're done. :) |
Great! It's nice to see that more and more people are enjoying our work 🎉 . If you have any questions, you can write me on Sylius Slack channel 🙂 . |
Hey guys, thanks for a nice plugin.
We will use it for an upcoming product but we need to extend the bundle a bit. And I want to see if it is of interest of your's and on the roadmap before considering doing a PR.
Product Block Type - We already extended our fork with a new block type adding linked products (just as a Page) since we need to control products within a block.
Containers - Next step will be to add containers to configure a layout that consist 1 or more blocks since this is not supported in a page. That would allow users to have more freedom to create more complex containers to be rendered in a twig.
Let me know your thoughts about it, and if it is any value for your project we would gladly contribute.
The text was updated successfully, but these errors were encountered: