Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximal direction extent #1009

Closed
eleftherioszisis opened this issue Mar 21, 2022 · 2 comments · Fixed by #1017
Closed

Maximal direction extent #1009

eleftherioszisis opened this issue Mar 21, 2022 · 2 comments · Fixed by #1017
Assignees

Comments

@eleftherioszisis
Copy link
Contributor

@lidakanari , asked for a maximal direction extent feature in #1008 (comment)

There are two ways to achieve this:

  1. Add a new feature that will return the maximum of the principal direction extents.
  2. Order the existing principal_direction_extent feature from max to min. The max extent would then be equal to principal_direction_extent(direction=0)

@arnaudon , @adrien-berchet, @mgeplf

@eleftherioszisis eleftherioszisis self-assigned this Mar 21, 2022
@arnaudon
Copy link
Contributor

I don't have strong opinion on that, maybe sorting the output of current feature would be enough. I'm not a user of that feature, so I'm not sure of its use cases and how its output is used down the line.

@lidakanari
Copy link
Contributor

Sorting the output would be sufficient for me as well. This is used for validation purposes and by default the axis=0 is outputed for the morph_stats app. So if the extents are sorted this will resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants