Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #1026

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Remove deprecations #1026

merged 3 commits into from
Apr 27, 2022

Conversation

eleftherioszisis
Copy link
Contributor

No description provided.

@eleftherioszisis eleftherioszisis force-pushed the zisis/remove-deprecated branch from 4c70983 to bbf6e03 Compare April 26, 2022 11:32
@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented Apr 27, 2022

@mgeplf I think the only thing left here is to decide if I should remove the viewer module. I am hesitant because the old way was more intuitive for the users compared to using the backend modules directly.

@mgeplf
Copy link
Collaborator

mgeplf commented Apr 27, 2022

I am hesitant because the old way was more intuitive for the users compared to using the backend modules directly.

Yeah, I think I agree about intuitive-ness.
However, in some cases, the plotly backend is nice; I wonder if we can just make it cleaner to select a different one? I don't have a proposal, at the moment, though.

@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented Apr 27, 2022

I am hesitant because the old way was more intuitive for the users compared to using the backend modules directly.

Yeah, I think I agree about intuitive-ness. However, in some cases, the plotly backend is nice; I wonder if we can just make it cleaner to select a different one? I don't have a proposal, at the moment, though.

ok, so let's not include the viewer related stuff in this PR and I will open a follow up one for the viewer. How about that? I will take a look at the viewer module and check if we can have a unified api with multiple backends. I am afraid that it might not be trivial given that it has not been done already.

@mgeplf
Copy link
Collaborator

mgeplf commented Apr 27, 2022

Sounds good.

I am afraid that it might not be trivial given that it has not been done already.

Likely; just give it a short thought and let me know what you come up with.

@eleftherioszisis eleftherioszisis merged commit 82ceb48 into v4 Apr 27, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/remove-deprecated branch April 27, 2022 19:30
eleftherioszisis added a commit that referenced this pull request Jun 7, 2022
Remove deprecated modules and deprecation warning. viewer module was not included to be treated separately
eleftherioszisis pushed a commit that referenced this pull request May 14, 2024
* Mixed subtree processing (#981)
* Refactor tests for test_mixed.py (#1027)
* Remove deprecated modules and functions/classes & warnings (#1026, #1032)
* Use readonly morphio Morphology by default (#979)
* Morphology level radial distance features use the soma as reference point (#1030)
* Expose subtree processing from the morph_stats api (#1034)
* Remove pyXX prefix for lint, docs, and coverage (#1038)
* Fix tutorials and add tutorial testenv (#1039)
* Add isort for formatting/linting (#1040)
* Add testing of example scripts (#1041)
* Make documentation/docstrings testable (#1035)
* Add black to neurom, format everything, and add to lint (#1042)
* Fix load_morpholgies to always resolve paths (#1047)
* allow Morphology objects to be either mut or immut (#1049)
* Replace iter_* methods by properties in core objects and improve iter_segments (#1054)
* Decouple Morphology constructor from io (#1120)
* Move soma methods to functions (#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants