Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add the description to payinvoice endpoint, if payment_request uses deschash #540

Open
rustyrussell opened this issue Mar 13, 2023 · 1 comment

Comments

@rustyrussell
Copy link

Hi!

I'm trying to ensure nodes see the full invoice they're paying, but as of now that's not possible with the current LndHub protocol, since you only hand the bolt11 string which may not contain the description (LNURL particularly likes to use the h description_hash field).

This is a real problem for node validation, since they don't know what they're paying, and for users who can't query their node to see what they actually paid (especially if they use multiple front-ends).

(Note: I discovered this issue because lnbits actually has an LndHub extension which means you can actually use BlueWallet to drive CLN, which is 🔥 😮 and @callebtc reported it in ElementsProject/lightning#6092 (comment)).

@joycekerkhof
Copy link

Can you explain this for me please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants