Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding the new 2023 "Pro Check Universal" device (M1017020A) #9

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: adding the new 2023 "Pro Check Universal" device (M1017020A) #9

merged 2 commits into from
Nov 16, 2023

Conversation

coffeehorn
Copy link
Contributor

@coffeehorn coffeehorn commented Nov 16, 2023 •
edited
Loading

Home Assistant Mopeka Integration fails to recognize the new 2023 Pro Check Universal device (see this issue)

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91a882c) 88.00% compared to head (e9f482c) 88.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files           2        2           
  Lines          75       75           
  Branches        5        5           
=======================================
  Hits           66       66           
  Misses          6        6           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coffeehorn coffeehorn changed the title feat(M1017020A): Adding Pro Check Universal device feat(M1017020A): adding the new 2023 "Pro Check Universal" device Nov 16, 2023
@coffeehorn coffeehorn changed the title feat(M1017020A): adding the new 2023 "Pro Check Universal" device feat: adding the new 2023 "Pro Check Universal" device (M1017020A) Nov 16, 2023
bdraco
bdraco approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coffeehorn
CI will release this shortly

@bdraco bdraco merged commit 0b81c71 into Bluetooth-Devices:main Nov 16, 2023
9 checks passed
@ak68-hub
Copy link

ak68-hub commented Jan 27, 2024 •
edited
Loading

It seems to be released already with Homeassistant-Dec 2023 Update.
But it doesn´t work: HA can´t find the Mopeka Universal Pro sensors in the Mopeka Integration.
Who got it to run ? Bdraco can you help me please ?

Fortunately the Victron Venus OS Update from 24/1/24 acceps the sensor NOW and it does work perfectly with a modbus-connection.

bdraco added a commit to home-assistant/core that referenced this pull request Jan 29, 2024
@bdraco
Add discovery support for the 2023 pro check model to mopkea
bffa148 
Bluetooth-Devices/mopeka-iot-ble#9 added
support for this and #104186 bumped the lib, but discovery
was never updated
This was referenced Jan 29, 2024
Merged
Closed
@ak68-hub
Copy link

ak68-hub commented Apr 19, 2024 •
edited
Loading

I´ve tried it again with HA-Core 2024.4.3 to add the Mopeka-Integration:
with the result: "No devices found"

At a Cerbo GX with Venus OS 3.30 all Mopeka Universal-Pro devices are found correctly :)

@bdraco bdraco mentioned this pull request Apr 21, 2024
Closed
@tispokes
Copy link

Same on 2024.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coffeehorn @ak68-hub @tispokes @bdraco