Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Separate Bolts into 2 Modules for Tasks and AppLinks #49

Closed
josephearl opened this issue Jan 22, 2015 · 5 comments
Closed

Separate Bolts into 2 Modules for Tasks and AppLinks #49

josephearl opened this issue Jan 22, 2015 · 5 comments
Assignees
Milestone

Comments

@josephearl
Copy link

I'd like to use the Task pattern in projects where I don't need AppLinks.

e.g. split Bolts into 2 modules:

Bolts/Tasks
Bolts/AppLinks // Depends on Tasks

Publish Bolts/AppLinks with the same Maven identifiers as currently used.

If desired AppLinks could further be split, into a part which does not rely on tasks and another that does:

Bolts/AppLinks
Bolts/Tasks
Bolts/AppLinksTasks // Depends on Tasks and AppLinks

With Bolts/AppLinks containing the core model, and Bolts/AppLinksTasks (or Bolts/AppLinksResolver).
Publish Bolts/AppLinksTasks with the same Maven identifiers as currently used.

If you're open to the idea I can submit a PR.

@ChaitanyaPramod
Copy link

Completely agree with the evaluation. I too believe that Bolts/Tasks is a complete module by itself, and should be broken off from AppLinks

@grantland
Copy link
Member

right now we're under bolts-android. would anyone have issues to moving Tasks to bolts-tasks and AppLinks to bolts-applinks as opposed to bolts-android-tasks and bolts-android-applinks? bolts-android could still be the umbrella for both Tasks and AppLinks.

@josephearl
Copy link
Author

Sounds good to me 👍

@grantland grantland self-assigned this May 22, 2015
@skyfishjy
Copy link

expect!

@grantland grantland added this to the 1.2.2 milestone Aug 27, 2015
@grantland
Copy link
Member

@josephearl @ChaitanyaPramod @skyfishjy Please take a look at #90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants