Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]h1 padding bottom value changed #3215

Merged
merged 7 commits into from
Feb 24, 2020
Merged

Conversation

nmsohn
Copy link
Contributor

@nmsohn nmsohn commented Aug 19, 2019

Description

image

Update:
I made changes to all headings. Now, if you keep typing lines, some horizontal lines disappear randomly on 80% and 90% views. I am looking into other markdown css at the moment

Issue fixed

#3211

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 20, 2019
browser/components/MarkdownPreview.js Outdated Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 21, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 more request, can you apply the same fix for other heading tag too? h1, h2, h3 etc. Thank you for your contribution 👍

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Aug 28, 2019

@nmsohn Are you still fixing it? Or you finished it?

@nmsohn
Copy link
Contributor Author

nmsohn commented Aug 29, 2019

@nmsohn Are you still fixing it? Or you finished it?

Hi,
I changed h1 and h2 paddings. As far as I see, I don't think there is h3. Let me know if more changes to be made:)

Update:
@ZeroX-DG Yes, you were right. Some headings still break. I am updating them all now

@ZeroX-DG
Copy link
Member

@nmsohn There're h1 -> h6. We should cover every cases in so that the bug doesn't happen again.

@nmsohn nmsohn changed the title h1 padding bottom value changed [WIP]h1 padding bottom value changed Aug 30, 2019
@Flexo013 Flexo013 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Aug 30, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your code. If you think of any better solution please share with me 😃

browser/components/MarkdownPreview.js Outdated Show resolved Hide resolved
browser/components/MarkdownPreview.js Outdated Show resolved Hide resolved
browser/components/MarkdownPreview.js Outdated Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 29, 2020
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Feb 12, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 24, 2020
@Rokt33r Rokt33r merged commit 5edce1f into BoostIO:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants