-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]h1 padding bottom value changed #3215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 more request, can you apply the same fix for other heading tag too? h1
, h2
, h3
etc. Thank you for your contribution 👍
@nmsohn Are you still fixing it? Or you finished it? |
@nmsohn There're h1 -> h6. We should cover every cases in so that the bug doesn't happen again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix your code. If you think of any better solution please share with me 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Description
Update:
I made changes to all headings. Now, if you keep typing lines, some horizontal lines disappear randomly on 80% and 90% views. I am looking into other markdown css at the moment
Issue fixed
#3211
Type of changes
Checklist: