Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Korean section of contributing.md #3453

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

baadaa
Copy link
Contributor

@baadaa baadaa commented Jan 30, 2020

Description

Update the Korean translation section of contribute.md. Prior to this commit, the section seemed to refer to an older version of the file and had missing parts.

Issue fixed

  • Update existing translations to better match recent changes to the contribution guides
  • Add new sentences to provide translations to newly added guides.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 30, 2020
@ZeroX-DG ZeroX-DG requested a review from Rokt33r January 30, 2020 04:58
@ZeroX-DG
Copy link
Member

@Rokt33r can you review this please?

@Rokt33r Rokt33r merged commit 6369963 into BoostIO:master Feb 3, 2020
@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Feb 3, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 3, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Feb 3, 2020

기여해주셔서 감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants