-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set COMPOSER_HOME #12
Comments
we could set the option in composer::home, and re-use it as default in composer::project |
So you mean defaulting to |
i'm starting to doubt the usfulness of generally, the hierarchy is:
however, composer::params, as a pattern, only makes sense if we're supposed to support (widely) different systems, where these params actually differ. as it is, we can simplify this chain down to:
|
Alright, I'll gladly go with this. |
well, then, please prepare a pull request! |
Apparently the current solution yields a warning in case
Gotta tweak this. |
i think we should establish Pull Requests for everything, i was a bit confused about your push to master :O (yes, that means i create pull requests for my pushes too.) |
Yeah, usually going via PR should be preferred, especially to wait for Travis confirmation. But in this case I have tried it locally on a development setup to actually develop the fix. ;-) |
nod |
Instead of the fallback to
HOME/.composer
one can explicitly setCOMPOSER_HOME
. This should be an option.I'm not sure about the best location though. Both
composer::$home
andcomposer::project::$home
come into mind where the former actually makes more sense but would make it harder forcomposer::project
to use.Suggestions?
The text was updated successfully, but these errors were encountered: