From 99e3d445fea952073cc033eed5efc8f8935c3275 Mon Sep 17 00:00:00 2001 From: Kamil Ronewicz Date: Fri, 2 Jun 2017 14:24:36 +0200 Subject: [PATCH 1/3] Fix debugging for docker for mac --- .vscode/launch.json | 4 +++- Dockerfile | 2 +- docker-compose.yml | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 2c0bb2e..1d2063a 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -6,7 +6,9 @@ "type": "node", "request": "attach", "protocol": "inspector", - "port": 9229 + "port": 9229, + "localRoot": "${workspaceRoot}", + "remoteRoot": "/opt/app" }, { "name": "Attach 5858 --debug", diff --git a/Dockerfile b/Dockerfile index 49e3354..a616550 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # if you're doing anything beyond your local machine, please pin this to a specific version at https://hub.docker.com/_/node/ -FROM node:6 +FROM node:7 RUN mkdir -p /opt/app diff --git a/docker-compose.yml b/docker-compose.yml index affc5aa..94e82c6 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -7,8 +7,8 @@ services: args: - NODE_ENV=development # you can use standard debug config or experimental node inspect - command: node --debug=5858 ../node_modules/nodemon/bin/nodemon.js - #command: node --inspect ../node_modules/nodemon/bin/nodemon.js + command: ../node_modules/.bin/nodemon --debug=0.0.0.0:5858 + #command: ../node_modules/.bin/nodemon --inspect=0.0.0.0:9229 ports: - "80:80" - "5858:5858" From 5ffa10e272762ed20fb6146a618b555ab70a4e40 Mon Sep 17 00:00:00 2001 From: Bret Fisher Date: Wed, 7 Jun 2017 03:13:57 -0400 Subject: [PATCH 2/3] Keeping at LTS branch for now --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index a616550..49e3354 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # if you're doing anything beyond your local machine, please pin this to a specific version at https://hub.docker.com/_/node/ -FROM node:7 +FROM node:6 RUN mkdir -p /opt/app From 3a431c7198cc898ceff124a2b54d4880ae35caae Mon Sep 17 00:00:00 2001 From: Bret Fisher Date: Wed, 7 Jun 2017 03:15:20 -0400 Subject: [PATCH 3/3] switching to new inspect --- docker-compose.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 94e82c6..483665c 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -6,9 +6,9 @@ services: context: . args: - NODE_ENV=development - # you can use standard debug config or experimental node inspect - command: ../node_modules/.bin/nodemon --debug=0.0.0.0:5858 - #command: ../node_modules/.bin/nodemon --inspect=0.0.0.0:9229 + # you can use legacy debug config or new inspect + #command: ../node_modules/.bin/nodemon --debug=0.0.0.0:5858 + command: ../node_modules/.bin/nodemon --inspect=0.0.0.0:9229 ports: - "80:80" - "5858:5858"