Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI Extension for Migrations messes up project migrations #148

Closed
JoppeDC opened this issue Feb 1, 2024 · 2 comments
Closed

DI Extension for Migrations messes up project migrations #148

JoppeDC opened this issue Feb 1, 2024 · 2 comments

Comments

@JoppeDC
Copy link
Contributor

JoppeDC commented Feb 1, 2024

The following DI extension should IMO not be included in this plugin:
https://github.com/Brille24/SyliusCustomOptionsPlugin/blob/master/src/DependencyInjection/Brille24SyliusCustomerOptionsExtension.php

This extension completely messes with the project migrations. Without any additional code and configuration, this will cause project migrations to generate in the vendor dir. Besides that, it will always load the bundle migrations, which shouldn't happen (these migratinos should be generated and run in the project itself). Besides that, the migrations included in the plugin also appear to be broken.

@mamazu
Copy link
Collaborator

mamazu commented Feb 1, 2024

Yes, this plugin still uses the old structure where the bundle generates the structure. The plugin needs to be updated. If you want to dig into that, I'd happily merge that.

This also ties into the xml to attribute migration. Sadly I have no experience with the migration.

@JoppeDC
Copy link
Contributor Author

JoppeDC commented Feb 2, 2024

Hi @mamazu , I've updated the doctrine entities to use the newer attributes, and removed the old way of migrations. If you have the time, please have a look at the changes. We can continue the conversation on the PR thread.

@JoppeDC JoppeDC closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants