Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PostgreSQL #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

firstred
Copy link
Contributor

This PR adds support for PostgreSQL by adjusting the migrations.

@mamazu
Copy link
Collaborator

mamazu commented Jun 16, 2023

Hey first of all thank you for adding migrations to support postgres. I have a couple of questions about this:

  1. How did you "generate" those migrations? Is there a flag that you used to because then we might want to document that as well so that we can create them correctly in the future. Or did you write them all by yourself?
  2. Correct me if I am wrong but I have read somewhere that the best approach to migrations would be to generate them on the project you are using the plugin in. So I though we might as well remove the migrations entirely and write just run doctrine:migration:diff into the docs.

With all this to say I am inclined to merge this since the plugin is pretty much "done".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants