Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add multiple select type min and max configuration constrain #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

julian-ladjani
Copy link

No description provided.

Copy link
Collaborator

@mamazu mamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for your contribution. There are just some minor things to add.

Please run our codestyle formatter (yeah we have our own guidelines). This will reduce the amount of changes.
Second, it would be great if you could add some tests for the new constraints in the constraint creator and Behat tests for checking that the constraints are working would be great.

@julian-ladjani
Copy link
Author

I have a problem with database saving, It save default values no edited values in form, I don't know why

@mamazu
Copy link
Collaborator

mamazu commented Feb 3, 2019

If you introduce a new constraint you need to manually upgrade the database fields for this type otherwise it will not work. Or just delete and recreate the customer options that are buggy.

@julian-ladjani
Copy link
Author

julian-ladjani commented Feb 3, 2019

It's not that, options "multi select" just save default values of configuration not edited values
image

@mamazu
Copy link
Collaborator

mamazu commented Feb 4, 2019

Is the field in the form type correctly named?

@mamazu mamazu force-pushed the master branch 2 times, most recently from a47f652 to 783f161 Compare May 21, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants