-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add multiple select type min and max configuration constrain #21
base: master
Are you sure you want to change the base?
[WIP] Add multiple select type min and max configuration constrain #21
Conversation
…nslation, fix select type configuration error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thanks for your contribution. There are just some minor things to add.
Please run our codestyle formatter (yeah we have our own guidelines). This will reduce the amount of changes.
Second, it would be great if you could add some tests for the new constraints in the constraint creator and Behat tests for checking that the constraints are working would be great.
I have a problem with database saving, It save default values no edited values in form, I don't know why |
If you introduce a new constraint you need to manually upgrade the database fields for this type otherwise it will not work. Or just delete and recreate the customer options that are buggy. |
Is the field in the form type correctly named? |
a47f652
to
783f161
Compare
No description provided.