CMake: Fix build on Android NDK #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android NDK does not have executables in the format of
aarch64-linux-android-clang++. Instead it provides executables in the
format aarch64-linux-android${ANDROID_ABI}-clang++. Since CMake 3.21 all
of this is handled by the toolchain file within Android NDK itself, so
there is no need to override the compilers anymore.
On Android pthread functionality is built into the C library and linking to pthread is not only needed but results in link failures.
p12tic
force-pushed
the
build-android
branch
from
0ebaa9a to
cd61761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android NDK does not have executables in the format of aarch64-linux-android-clang++. Instead it provides executables in the format aarch64-linux-android${ANDROID_ABI}-clang++. Since CMake 3.21 all of this is handled by the toolchain file within Android NDK itself, so there is no need to override the compilers anymore.
Additionally, on Android pthread functionality is built into the C library and linking to pthread is not only needed but results in link failures.