Notification dbus refactor #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bunch of stuff missing, but this should be a good start. The main issue I'm running into so far is I can't quite come up with a way to allow other parts to interact with this server.
This should be the same or super close to the existing notification popup widget in use. This also adds tracking in the DBus server for active popups. The idea for this is that there is a central place (here) to show notification popups. That way, Raven can focus on its own view for stored notifications without having to deal with the popup logic. Hopefully, Raven will somehow be able to use the new notification class without having to duplicate a ton of logic.
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
This is really a part 1 or 2, because the next step is to change everything to use the control center DND setting. Signed-off-by: Evan Maddock <[email protected]>
This marks the first time that the new notification system can actually work. Many initial issues with the popups and popup system have already been fixed as a result of this. There seems to be some weirdness with certain notifications, primarily from Discord, where the notifications will appear on top of each other.
This seems to mostly prevent Discord popups being weird.
This gives a better way to replace a notification.
Meson can get really pedantic with link order. Also fixed NotificationPosition being used in Budgie Desktop Settings.
Much of this code is the same as before the refactor, just modified to use the new DBus names and classes.
There is a bunch of stuff missing, but this should be a good start. The main issue I'm running into so far is I can't quite come up with a way to allow other parts to interact with this server.
This should be the same or super close to the existing notification popup widget in use. This also adds tracking in the DBus server for active popups. The idea for this is that there is a central place (here) to show notification popups. That way, Raven can focus on its own view for stored notifications without having to deal with the popup logic. Hopefully, Raven will somehow be able to use the new notification class without having to duplicate a ton of logic.
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
This is really a part 1 or 2, because the next step is to change everything to use the control center DND setting. Signed-off-by: Evan Maddock <[email protected]>
This marks the first time that the new notification system can actually work. Many initial issues with the popups and popup system have already been fixed as a result of this. There seems to be some weirdness with certain notifications, primarily from Discord, where the notifications will appear on top of each other.
This seems to mostly prevent Discord popups being weird.
This gives a better way to replace a notification.
Meson can get really pedantic with link order. Also fixed NotificationPosition being used in Budgie Desktop Settings.
Much of this code is the same as before the refactor, just modified to use the new DBus names and classes.
…ie/budgie-desktop into notification-dbus-refactor
This also makes sure we put a notification into Raven when popups are paused or disabled.
|
Oh yeah, I forgot: the notification server name still reports as Raven. Should this be changed to something more agnostic? |
JoshStrobl
requested changes
Jan 14, 2022
|
I'm not sure about the subproject thing either... Or where it came from. I don't see that commit in this changeset O.o hmm... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the entire notification system. Some benefits of this are outlined in #23, #25, and #21. The main thing is that there is a dedicated notification server implementing the Freedesktop spec, and having a separate dedicated DBus server to "repeat" notifications and closings. This second server can then be listened to by, e.g. Raven to display notifications in other ways. This work makes it much easier to work with notifications.
This PR needs significant testing before merging to ensure that everything works properly and that there are no regressions compared to current Budgie.
Testing
If you wish to help test this work, checkout and build the
notification-dbus-refactorbranch. Then either re-log or open a terminal and runbudgie-daemon --replace &!andbudgie-panel --replace &!.Changes
Some changes were made to notification handling to better conform to the Freedesktop spec and/or to make development life easier:
Submitter Checklist
git rebase -i(if needed)