From 50811c5e8593bcf37bfb7d37fd9c511fa75d94c9 Mon Sep 17 00:00:00 2001
From: salim ben ahben <40862545+Sben65@users.noreply.github.com>
Date: Thu, 27 Jan 2022 15:38:21 +0100
Subject: [PATCH] Issue #103 gateway module log modal is out of the screen for
 large logs (#116)

* fix #88 (#92)

Co-authored-by: ben salim <salim.benahben@cgi.com>

* fix #76 check the DevEui at device creation

* adding scroll in the logs modal

* fix #103

* fix #76 check the DevEui at device creation

* adding scroll in the logs modal

* fix #103

* add of missing code

* add of missing code

* code cleanup

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
---
 .../Client/Pages/Gateways/Detail.razor                |  2 +-
 .../Client/Pages/Gateways/Logs.razor                  | 11 +++++++----
 .../Server/Controllers/DevicesController.cs           |  1 -
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/AzureIoTHub.Portal/Client/Pages/Gateways/Detail.razor b/src/AzureIoTHub.Portal/Client/Pages/Gateways/Detail.razor
index b61167b88..fed2a74e3 100644
--- a/src/AzureIoTHub.Portal/Client/Pages/Gateways/Detail.razor
+++ b/src/AzureIoTHub.Portal/Client/Pages/Gateways/Detail.razor
@@ -262,7 +262,7 @@ else
             Snackbar.Add($"Error<br>Status : {c2dResult.Status};<br>Payload : {c2dResult.Payload};", Severity.Error,
                 (option) =>
                 {
-                    option.VisibleStateDuration = 100000;
+                    option.VisibleStateDuration = 10000;
                 });
         }
     }
diff --git a/src/AzureIoTHub.Portal/Client/Pages/Gateways/Logs.razor b/src/AzureIoTHub.Portal/Client/Pages/Gateways/Logs.razor
index 2629e8567..b19e30bff 100644
--- a/src/AzureIoTHub.Portal/Client/Pages/Gateways/Logs.razor
+++ b/src/AzureIoTHub.Portal/Client/Pages/Gateways/Logs.razor
@@ -3,9 +3,9 @@
 @using Newtonsoft.Json;
 
 
-<MudDialog>
+<MudDialog Style="max-width:fit-content;">
     <DialogContent>
-        <MudCard Outlined="true" >
+        <MudCard Outlined="true" Style="width:800px;max-height: 600px; overflow-y: scroll">
             <MudCardContent>
 
                 <MudItem xs="12">
@@ -13,7 +13,7 @@
                     <ColGroup>
                         <col style="width: 20%;" />
                         <col style="width: 10%;" />
-                        <col style="width: 30%;" />
+                        <col style="width: 40%;" />
                     </ColGroup>
 
                     <HeaderContent>
@@ -26,7 +26,10 @@
                             @context.TimeStamp
                         </MudTd>
                         <MudTd DataLabel="Type" Style="text-align: center">@context.LogLevel</MudTd>
-                        <MudTd DataLabel="NbDevices" Style="text-align: center;word-break: break-all;">@context.Text</MudTd>
+                        <MudTd DataLabel="NbDevices" Style="text-align: center;">
+                            <MudTextField T="string" Text="@context.Text" Lines="3" Disabled="true"></MudTextField>
+                        </MudTd>
+                        @*<MudTd DataLabel="NbDevices" Style="text-align: center;word-break: break-all;">@context.Text</MudTd>*@
                     </RowTemplate>
                     <PagerContent>
                         <MudTablePager PageSizeOptions="@pageSizeOptions"></MudTablePager>
diff --git a/src/AzureIoTHub.Portal/Server/Controllers/DevicesController.cs b/src/AzureIoTHub.Portal/Server/Controllers/DevicesController.cs
index 743a6bc52..e566721e0 100644
--- a/src/AzureIoTHub.Portal/Server/Controllers/DevicesController.cs
+++ b/src/AzureIoTHub.Portal/Server/Controllers/DevicesController.cs
@@ -59,7 +59,6 @@ public async Task<IEnumerable<DeviceListItem>> Get()
         {
             // Gets all the twins from this devices
             var items = await this.devicesService.GetAllDevice();
-            var results = new List<DeviceListItem>();
 
             return items.Select(this.deviceTwinMapper.CreateDeviceListItem);
         }