Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Pagination in query might be useless #308

Closed
2 tasks
audserraCGI opened this issue Feb 23, 2022 · 0 comments
Closed
2 tasks

Bug: Pagination in query might be useless #308

audserraCGI opened this issue Feb 23, 2022 · 0 comments
Assignees
@kbeaugrand
Labels
bug Something isn't working
Milestone
S14

Comments

@audserraCGI
Copy link
Contributor

audserraCGI commented Feb 23, 2022 •
edited by kbeaugrand
Loading

Current Behavior

Use of pagination in the query might be useless :

File : LoraWANCommandsController.cs
Function : public async Task<IActionResult> Post(string id, DeviceModelCommand[] commands)

image

  • LoRaWanCommandsController
  • DeviceTagsSettingsController
@audserraCGI audserraCGI added the bug Something isn't working label Feb 23, 2022
@kbeaugrand kbeaugrand self-assigned this Mar 3, 2022
@kbeaugrand kbeaugrand added this to the S14 milestone Mar 3, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Mar 3, 2022
kbeaugrand added a commit that referenced this issue Mar 3, 2022
@kbeaugrand
Fix #308 - Remove useless pages in table queries
f3d4920
audserraCGI added a commit that referenced this issue Mar 4, 2022
@audserraCGI @kbeaugrand
Set device tags on device create/details screens (#366)
b1e1f0f 
* Fix Namespace issue

* Added DeviceTagService + Custom tags on CreateDevicePage

* Customised tag on DeviceDetailPage

* List<DeviceTag> changed to List<string> in CreateDeviceDetails()

* Fix DeviceMapper Tests to work with new DeviceDetails model

* Fix DevicesControllerTests with new DeviceDetails model

* Added DeviceTagService Test

* Added DEviceTagsSettingsController test

* Fix Namespace issue

* Added DeviceTagService + Custom tags on CreateDevicePage

* Customised tag on DeviceDetailPage

* List<DeviceTag> changed to List<string> in CreateDeviceDetails()

* Fix DeviceMapper Tests to work with new DeviceDetails model

* Fix DevicesControllerTests with new DeviceDetails model

* Added DeviceTagService Test

* Added DEviceTagsSettingsController test

* Fixed typo when merging

* Fix code scanning errors

* Small fix

* Added form validation on front side

* Added form validation on Edit page

* Fix comments

* Fix #362 - Update API version + Better treat errors (#378)

* Fix #308 - Remove useless pages in table queries (#379)

* Fix #308 - Remove useless pages in table queries

* Add some unit test to increase code coverage

* Fix tests and clear code

* Fix change in pagination conflict

* Fix Namespace issue

* Added DeviceTagService + Custom tags on CreateDevicePage

* Customised tag on DeviceDetailPage

* List<DeviceTag> changed to List<string> in CreateDeviceDetails()

* Fix DeviceMapper Tests to work with new DeviceDetails model

* Fix DevicesControllerTests with new DeviceDetails model

* Added DeviceTagService Test

* Added DEviceTagsSettingsController test

* Added DeviceTagService + Custom tags on CreateDevicePage

* List<DeviceTag> changed to List<string> in CreateDeviceDetails()

* Added DeviceTagService Test

* Added DEviceTagsSettingsController test

* Fixed typo when merging

* Fix code scanning errors

* Small fix

* Added form validation on front side

* Added form validation on Edit page

* Fix comments

* Fix tests and clear code

* Fix change in pagination conflict

* Update src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettingsController.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>

Co-authored-by: Kevin BEAUGRAND <[email protected]>
@github-actions github-actions bot mentioned this issue Mar 4, 2022
Merged
@kbeaugrand kbeaugrand moved this from :pencil: Todo to :rocket: Ready in IoT Hub Portal Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbeaugrand kbeaugrand

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S14
Development

No branches or pull requests
2 participants
@kbeaugrand @audserraCGI