Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Enrollment group creation based on device model name #413

Closed
adcoly opened this issue Mar 9, 2022 · 2 comments · Fixed by #435
Closed

Bug: Enrollment group creation based on device model name #413

adcoly opened this issue Mar 9, 2022 · 2 comments · Fixed by #435
Assignees
Labels
bug Something isn't working
Milestone

Comments

@adcoly
Copy link

adcoly commented Mar 9, 2022

Expected Behavior

When I create a new device model, the enrollment created should have its name based on the model id and not the model name.
When I update the name of a device model, this should not create a new enrollement group for the same device model.

Context (Environment)

Portal version: 1.0.4

Logs

Json used to create a device model that triggered an error :
model_json

@adcoly adcoly added the bug Something isn't working label Mar 9, 2022
@adcoly
Copy link
Author

adcoly commented Mar 9, 2022

Additional information:
Here is the error after a curl command on the web API :
deploy_model_nke

Here is a json file that does not triggered any error:
model_json_np

Here is the location where the enrollment group is created in the code :

return await this.CreateNewEnrollmentGroup(modelName, false, twinState);

@kbeaugrand
Copy link
Member

Discussed today :

  • Create the enrollment group with the device model ID instead of the model name

@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Mar 10, 2022
@kbeaugrand kbeaugrand added this to the S14 milestone Mar 10, 2022
@audserraCGI audserraCGI self-assigned this Mar 11, 2022
@audserraCGI audserraCGI moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Mar 11, 2022
@audserraCGI audserraCGI linked a pull request Mar 11, 2022 that will close this issue
9 tasks
@audserraCGI audserraCGI moved this from :construction: In Progress to :rocket: Ready in IoT Hub Portal Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

3 participants