Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update favicon #888

Closed
hocinehacherouf opened this issue Jun 29, 2022 · 0 comments
Closed

Feature: Update favicon #888

hocinehacherouf opened this issue Jun 29, 2022 · 0 comments
Assignees
@hocinehacherouf
Labels
enhancement New feature or request
Milestone
S31

Comments

@hocinehacherouf
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current favicon is the one proposed by default by blazor:

image

Describe the solution you'd like

We can reuse the main loading logo as favicon:

image
@hocinehacherouf hocinehacherouf added enhancement New feature or request refinement labels Jun 29, 2022
@hocinehacherouf hocinehacherouf added this to the S31 milestone Jul 1, 2022
@hocinehacherouf hocinehacherouf self-assigned this Jul 1, 2022
@hocinehacherouf hocinehacherouf moved this to :pencil: Todo in IoT Hub Portal Jul 3, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Jul 3, 2022
hocinehacherouf added a commit that referenced this issue Jul 3, 2022
@hocinehacherouf
Add new favicon with inverted color in dark mode #888
8e84df2
hocinehacherouf added a commit that referenced this issue Jul 3, 2022
@hocinehacherouf
Update pwa manifest to target new favicon as icon #888
83f5f38
hocinehacherouf added a commit that referenced this issue Jul 3, 2022
@hocinehacherouf
Add favicons on index.html #888
28820ac
@hocinehacherouf hocinehacherouf mentioned this issue Jul 3, 2022
Merged
9 tasks
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Jul 3, 2022
hocinehacherouf added a commit that referenced this issue Jul 3, 2022
@hocinehacherouf
Update favicon #888 (#897)
bbbc9c6 
* Delete old favicon + pwa icon

* Add new favicon with inverted color in dark mode #888

* Update pwa manifest to target new favicon as icon #888

* Add favicons on index.html #888
@hocinehacherouf hocinehacherouf moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hocinehacherouf hocinehacherouf

Labels
enhancement New feature or request
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S31
Development

No branches or pull requests
1 participant
@hocinehacherouf