Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/loading authentication service #1076

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 11, 2022

Description

What's new?

  • Fix AuthenticationService javascript file loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review August 11, 2022 12:43
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 11, 2022 12:43
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1076 (db5d2a3) into main (7bd1771) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         179      179           
  Lines        5861     5861           
=======================================
  Hits         5009     5009           
  Misses        852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hocinehacherouf hocinehacherouf enabled auto-merge (squash) August 11, 2022 12:46
@hocinehacherouf hocinehacherouf merged commit 728e11c into main Aug 11, 2022
@hocinehacherouf hocinehacherouf deleted the fix/loading_authentication_service branch August 11, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants