Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #80 #199

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Fix #80 #199

merged 2 commits into from
Feb 5, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 5, 2022 •
edited
Loading

Description

What's new?

  • fix some code QL analysis errors

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Checklist before merge

Developer's responsibilities

  • This pull request merges to main
  • Approved by at least one developer
  • Pull request build has passed
  • Staging app has been deployed successfully

Product Owner's responsibilities

  • No issues have been found on staging environment
  • Product Owner has approved the release

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 5, 2022 09:12
@kbeaugrand kbeaugrand merged commit a23d083 into main Feb 5, 2022
@kbeaugrand kbeaugrand deleted the fix/code_ql_fixes branch February 5, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kbeaugrand