Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Remove Code QL errors #201

Merged
merged 3 commits into from
Feb 5, 2022
Merged

WIP: Remove Code QL errors #201

merged 3 commits into from
Feb 5, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 5, 2022 •
edited
Loading

Description

What's new?

  • Fix Dereferenced variable may be null

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Checklist before merge

Developer's responsibilities

  • This pull request merges to main
  • Approved by at least one developer
  • Pull request build has passed
  • Staging app has been deployed successfully

Product Owner's responsibilities

  • No issues have been found on staging environment
  • Product Owner has approved the release

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 5, 2022 12:09
@kbeaugrand kbeaugrand changed the title Fix Dereferenced variable may be null WIP: Remove Code QL errors Feb 5, 2022
@kbeaugrand
Copy link
Member Author

Hi @Sben65 and @audserraCGI,

This is a Work In Progress PR.
Please do not merge it until I've finish the work.

@Sben65 Sben65 merged commit e35dd7f into main Feb 5, 2022
@Sben65 Sben65 deleted the fix/code_ql_fixes branch February 5, 2022 13:33
@kbeaugrand kbeaugrand restored the fix/code_ql_fixes branch February 5, 2022 14:37
kbeaugrand added a commit that referenced this pull request Feb 5, 2022
@kbeaugrand
Revert "WIP: Remove Code QL errors (#201)"
8fca6fd 
This reverts commit e35dd7f.
@kbeaugrand kbeaugrand mentioned this pull request Feb 5, 2022
Merged
kbeaugrand added a commit that referenced this pull request Feb 5, 2022
@kbeaugrand
Revert "WIP: Remove Code QL errors (#201)" (#204)
b3f73e3 
This reverts commit e35dd7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sben65 Sben65 Sben65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbeaugrand @Sben65