Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL analysis alerts #205

Merged
merged 18 commits into from
Feb 6, 2022
Merged

Fix CodeQL analysis alerts #205

merged 18 commits into from
Feb 6, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 5, 2022

Description

What's new?

  • Fix CodeQL alerts

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Checklist before merge

Developer's responsibilities

  • This pull request merges to main
  • Approved by at least one developer
  • Pull request build has passed
  • Staging app has been deployed successfully

Product Owner's responsibilities

  • No issues have been found on staging environment
  • Product Owner has approved the release

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 5, 2022 17:14
@kbeaugrand kbeaugrand force-pushed the fix/code_ql_fixes branch 2 times, most recently from 75490cd to 76c6b1d Compare February 5, 2022 18:17
@kbeaugrand kbeaugrand changed the title Fix/code ql fixes WIP: Fix/code ql fixes Feb 5, 2022
@kbeaugrand kbeaugrand force-pushed the fix/code_ql_fixes branch 2 times, most recently from 85f93c5 to 9d333d0 Compare February 6, 2022 11:19
@kbeaugrand kbeaugrand changed the title WIP: Fix/code ql fixes Fix CodeQL analysis alerts Feb 6, 2022
@kbeaugrand kbeaugrand force-pushed the fix/code_ql_fixes branch 2 times, most recently from 40acaa7 to 3589f30 Compare February 6, 2022 11:32
@kbeaugrand kbeaugrand force-pushed the main branch 4 times, most recently from 82ea39e to 48cdf31 Compare February 6, 2022 13:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #205 (7e1b539) into main (233066b) will decrease coverage by 0.01%.
The diff coverage is 1.27%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #205      +/-   ##
========================================
- Coverage   0.66%   0.64%   -0.02%     
========================================
  Files         71      71              
  Lines       2414    2324      -90     
========================================
- Hits          16      15       -1     
+ Misses      2398    2309      -89     
Impacted Files Coverage Δ
...ub.Portal/Server/Controllers/CommandsController.cs 0.00% <0.00%> (ø)
...Hub.Portal/Server/Controllers/ConfigsController.cs 0.00% <0.00%> (ø)
...ortal/Server/Controllers/DeviceModelsController.cs 0.00% <0.00%> (ø)
...Hub.Portal/Server/Controllers/DevicesController.cs 0.00% <0.00%> (ø)
...ub.Portal/Server/Controllers/GatewaysController.cs 0.00% <0.00%> (ø)
...ub.Portal/Server/Filters/ApiRequiredScopeFilter.cs 0.00% <ø> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 0.00% <0.00%> (ø)
....Portal/Server/Managers/ConnectionStringManager.cs 0.00% <0.00%> (ø)
...erver/Managers/DeviceProvisioningServiceManager.cs 0.00% <0.00%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/DeviceHelper.cs 15.15% <11.76%> (-0.35%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233066b...7e1b539. Read the comment docs.

@kbeaugrand kbeaugrand merged commit ddec3d4 into main Feb 6, 2022
@kbeaugrand kbeaugrand deleted the fix/code_ql_fixes branch February 6, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants