Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit tests for mappers #206

Merged
merged 3 commits into from
Feb 6, 2022
Merged

Add Unit tests for mappers #206

merged 3 commits into from
Feb 6, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 6, 2022 •
edited
Loading

Description

What's new?

  • Add unit tests for the solution

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 6, 2022 15:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #206 (1bf5f47) into main (ddec3d4) will increase coverage by 5.38%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #206      +/-   ##
========================================
+ Coverage   0.64%   6.02%   +5.38%     
========================================
  Files         71      71              
  Lines       2324    2323       -1     
========================================
+ Hits          15     140     +125     
+ Misses      2309    2183     -126
Impacted Files Coverage Δ
...IoTHub.Portal/Server/Extensions/StringExtension.cs 83.33% <ø> (ø)
....Portal/Server/Mappers/DeviceModelCommandMapper.cs 100.00% <ø> (+100.00%) ⬆️
...reIoTHub.Portal/Server/Mappers/DeviceTwinMapper.cs 100.00% <ø> (+100.00%) ⬆️
.../AzureIoTHub.Portal/Server/Helpers/DeviceHelper.cs 27.27% <0.00%> (+12.12%) ⬆️
...THub.Portal/Shared/Models/Device/DeviceListItem.cs 75.00% <0.00%> (+75.00%) ⬆️
...oTHub.Portal/Shared/Models/Device/DeviceDetails.cs 93.33% <0.00%> (+93.33%) ⬆️
...rc/AzureIoTHub.Portal/Shared/Models/DeviceModel.cs 100.00% <0.00%> (+100.00%) ⬆️
...AzureIoTHub.Portal/Shared/Models/Device/Command.cs 100.00% <0.00%> (+100.00%) ⬆️
...eIoTHub.Portal/Server/Mappers/DeviceModelMapper.cs 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddec3d4...1bf5f47. Read the comment docs.

@kbeaugrand kbeaugrand changed the title WIP: Add Unit tests for device model command mapper Add Unit tests for mappers Feb 6, 2022
@kbeaugrand kbeaugrand added the .NET Pull requests that update .net code label Feb 6, 2022
@kbeaugrand kbeaugrand merged commit b4f0ce9 into main Feb 6, 2022
@kbeaugrand kbeaugrand deleted the feature/add_unitary_tests branch February 6, 2022 18:27
kbeaugrand added a commit that referenced this pull request Feb 6, 2022
@Sben65 @kbeaugrand
fix #179 error while deleting a gateway (#203)
a790234 
* fix #179

* change "LoRa Device" to "LoRa Network Server"

* Fix compilation issue

* Add Unit tests for mappers (#206)

* Add Unit tests for device model command mapper

* Add Unit tests for device model mapper

* Add unit tests for device twin mapper

* fix #179

* change "LoRa Device" to "LoRa Network Server"

Co-authored-by: Beaugrand, Kevin <[email protected]>
Co-authored-by: Kevin BEAUGRAND <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
.NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbeaugrand @codecov-commenter