Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #219 - Remove generic catch clause #220

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 8, 2022

Description

What's new?

  • Fix generic catch clause

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 8, 2022 17:17
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #220 (5a72e15) into main (a4da4b3) will increase coverage by 1.75%.
The diff coverage is 100.00%.

❗ Current head 5a72e15 differs from pull request most recent head a58404a. Consider uploading reports for the commit a58404a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            main     #220      +/-   ##
=========================================
+ Coverage   8.38%   10.14%   +1.75%     
=========================================
  Files         71       71              
  Lines       2361     2357       -4     
=========================================
+ Hits         198      239      +41     
+ Misses      2163     2118      -45     
Impacted Files Coverage Δ
...ub.Portal/Server/Controllers/GatewaysController.cs 20.49% <100.00%> (+20.49%) ⬆️
.../AzureIoTHub.Portal/Server/Helpers/DeviceHelper.cs 41.93% <0.00%> (+6.45%) ⬆️
...zureIoTHub.Portal/Shared/Models/GatewayListItem.cs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4da4b3...a58404a. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/219_remove_generic_catch branch from 5a72e15 to 70cbb97 Compare February 8, 2022 21:06
@kbeaugrand kbeaugrand force-pushed the fix/219_remove_generic_catch branch from 70cbb97 to 7387e37 Compare February 8, 2022 21:06
@kbeaugrand kbeaugrand force-pushed the fix/219_remove_generic_catch branch from 7387e37 to a58404a Compare February 9, 2022 06:20
@kbeaugrand kbeaugrand merged commit 6b677ce into main Feb 9, 2022
@kbeaugrand kbeaugrand deleted the fix/219_remove_generic_catch branch February 9, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants