Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add unitary tests #221

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix/add unitary tests #221

merged 1 commit into from
Feb 9, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 9, 2022

Description

What's new?

  • Add unitary test on gateway creation

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 9, 2022 09:52
@kbeaugrand kbeaugrand force-pushed the fix/add_unitary_tests branch 2 times, most recently from 827e957 to 363628f Compare February 9, 2022 09:57
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #221 (7657883) into main (6b677ce) will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   10.26%   11.28%   +1.01%     
==========================================
  Files          71       71              
  Lines        2357     2357              
==========================================
+ Hits          242      266      +24     
+ Misses       2115     2091      -24     
Impacted Files Coverage Δ
...ub.Portal/Server/Controllers/GatewaysController.cs 27.95% <0.00%> (+5.59%) ⬆️
src/AzureIoTHub.Portal/Shared/Models/Gateway.cs 55.55% <0.00%> (+55.55%) ⬆️
src/AzureIoTHub.Portal/Shared/Models/ConfigItem.cs 71.42% <0.00%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b677ce...7657883. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/add_unitary_tests branch from 363628f to 7657883 Compare February 9, 2022 10:09
@kbeaugrand kbeaugrand merged commit 5f7ba5c into main Feb 9, 2022
@kbeaugrand kbeaugrand deleted the fix/add_unitary_tests branch February 9, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants