Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove eui helper #224

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Refactor/remove eui helper #224

merged 3 commits into from
Feb 9, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 9, 2022

Description

What's new?

  • Remove useless code
  • Add unit tests on devices controller

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 9, 2022 12:21
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #224 (b903c2d) into main (68c5a9a) will increase coverage by 4.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   12.34%   17.15%   +4.81%     
==========================================
  Files          71       67       -4     
  Lines        2357     2005     -352     
==========================================
+ Hits          291      344      +53     
+ Misses       2066     1661     -405     
Impacted Files Coverage Δ
...Hub.Portal/Server/Controllers/DevicesController.cs 66.25% <100.00%> (+66.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c5a9a...b903c2d. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the refactor/remove_eui_helper branch from 7dc1363 to 97e550e Compare February 9, 2022 13:59
@kbeaugrand kbeaugrand force-pushed the refactor/remove_eui_helper branch from 113a2d3 to e50bb24 Compare February 9, 2022 16:11
@kbeaugrand kbeaugrand merged commit e812a39 into main Feb 9, 2022
@kbeaugrand kbeaugrand deleted the refactor/remove_eui_helper branch February 9, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants