Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage LoRa and non-LoRa Devices #247

Merged
merged 7 commits into from
Feb 17, 2022
Merged

Manage LoRa and non-LoRa Devices #247

merged 7 commits into from
Feb 17, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Feb 11, 2022 •
edited by kbeaugrand
Loading

Description

What's new?

  • Separate APIs to have lorawan low-level features
  • Add lorawan APIs
  • Merge the APIS into one screen

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner February 11, 2022 16:39
@kbeaugrand kbeaugrand force-pushed the main branch 4 times, most recently from 7b469b7 to 16aa221 Compare February 13, 2022 15:10
@kbeaugrand kbeaugrand force-pushed the 171_manage_non_lora_device branch 4 times, most recently from a22de4b to 16f823f Compare February 15, 2022 12:44
@codecov
Copy link

codecov bot commented Feb 15, 2022 •
edited
Loading

Codecov Report

Merging #247 (ae549ae) into main (2763ab0) will increase coverage by 1.37%.
The diff coverage is 48.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   28.71%   30.08%   +1.37%     
==========================================
  Files          77       93      +16     
  Lines        2417     2672     +255     
==========================================
+ Hits          694      804     +110     
- Misses       1723     1868     +145
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/DeleteDeviceModelPage.razor 0.00% <ø> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 0.00% <0.00%> (ø)
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <0.00%> (ø)
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeleteDevicePage.razor 0.00% <ø> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2763ab0...ae549ae. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the 171_manage_non_lora_device branch 9 times, most recently from ae5c052 to c8a4b37 Compare February 17, 2022 13:42
@audserraCGI @kbeaugrand
Fix compilation issues
39b2a29 
DeviceModelDetailPage split into two different tabs (front only)

DeviceModelsController split into two files to separate basic model from LoRa model

DeviceModel creation on different tabs (front only)

DeviceModel creation on different tabs (front only)

New DTO : LoRaDeviceDetail and LoraDeviceModel

Delete specific fields from DeviceListItem & DeviceList search panel
@kbeaugrand kbeaugrand force-pushed the 171_manage_non_lora_device branch from c8a4b37 to 39b2a29 Compare February 17, 2022 13:59
@kbeaugrand kbeaugrand force-pushed the 171_manage_non_lora_device branch from 40ad80e to 31fac83 Compare February 17, 2022 14:35
@kbeaugrand kbeaugrand changed the title WIP : Manage LoRa and non-LoRa DeviceModels Manage LoRa and non-LoRa Devices Feb 17, 2022
kbeaugrand
kbeaugrand approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Huge of rework on this PR!
Related to #171 feature request

@kbeaugrand kbeaugrand merged commit b43f317 into main Feb 17, 2022
@kbeaugrand kbeaugrand deleted the 171_manage_non_lora_device branch February 17, 2022 15:43
@github-actions github-actions bot mentioned this pull request Feb 17, 2022
Merged
@kbeaugrand kbeaugrand linked an issue Feb 17, 2022 that may be closed by this pull request
Manage Non-LoRa Devices #171
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage Non-LoRa Devices
2 participants
@audserraCGI @kbeaugrand