Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all un necessary usings in the solution #252

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 12, 2022

Description

What's new?

  • Refactoring; remove all occurences of un necessary usings

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 12, 2022 18:18
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #252 (f1abb16) into main (84242c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files          77       77           
  Lines        2289     2289           
=======================================
  Hits          464      464           
  Misses       1825     1825           
Impacted Files Coverage Δ
src/AzureIoTHub.Portal/Client/Program.cs 0.00% <ø> (ø)
...ub.Portal/Server/Controllers/CommandsController.cs 0.00% <ø> (ø)
...rtal/Server/Controllers/ConcentratorsController.cs 75.38% <ø> (ø)
...Hub.Portal/Server/Controllers/ConfigsController.cs 0.00% <ø> (ø)
...ortal/Server/Controllers/DeviceModelsController.cs 0.00% <ø> (ø)
...Hub.Portal/Server/Controllers/DevicesController.cs 68.60% <ø> (ø)
...ub.Portal/Server/Controllers/GatewaysController.cs 36.02% <ø> (ø)
...ortal/Server/Controllers/OIDCSettingsController.cs 0.00% <ø> (ø)
...THub.Portal/Server/Factories/TableClientFactory.cs 0.00% <ø> (ø)
...rtal/Server/Managers/DeviceModelCommandsManager.cs 90.47% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84242c2...f1abb16. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/fix_code_ql_notes_unnecessary_usings branch 3 times, most recently from 47b64a9 to 025fd21 Compare February 12, 2022 18:59
@kbeaugrand kbeaugrand force-pushed the fix/fix_code_ql_notes_unnecessary_usings branch from 025fd21 to f1abb16 Compare February 12, 2022 19:05
@kbeaugrand kbeaugrand merged commit 146f8e9 into main Feb 12, 2022
@kbeaugrand kbeaugrand deleted the fix/fix_code_ql_notes_unnecessary_usings branch February 12, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant