Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review apis consistency #253

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Review apis consistency #253

merged 3 commits into from
Feb 13, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 13, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 13, 2022 09:49
@kbeaugrand kbeaugrand changed the title Fix/250 review apis consistency Review apis consistency Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #253 (3b028ba) into main (146f8e9) will decrease coverage by 0.02%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   20.27%   20.24%   -0.03%     
==========================================
  Files          77       77              
  Lines        2289     2292       +3     
==========================================
  Hits          464      464              
- Misses       1825     1828       +3     
Impacted Files Coverage Δ
...tal/Client/Pages/Configurations/ConfigDetail.razor 0.00% <0.00%> (ø)
...b.Portal/Client/Pages/Configurations/Configs.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/DeleteDeviceModelPage.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...nt/Pages/Edge_Devices/CreateEdgeDeviceDialog.razor 0.00% <0.00%> (ø)
...e_Devices/EdgeDeviceDeleteConfirmationDialog.razor 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146f8e9...3b028ba. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 5fb6da9 into main Feb 13, 2022
@kbeaugrand kbeaugrand deleted the fix/250_review_apis_consistency branch February 13, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant