Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter devices at iot hub level #270

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 15, 2022

Description

#243

What's new?

  • Internal changes to query devices nd filter it at the IoT Hub query
  • Add new unit tests to cover the IoT Hub Registry manager wrapper

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 15, 2022 14:38
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #270 (73edbb9) into main (9e060d6) will increase coverage by 1.95%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   26.76%   28.71%   +1.95%     
==========================================
  Files          77       77              
  Lines        2425     2417       -8     
==========================================
+ Hits          649      694      +45     
+ Misses       1776     1723      -53     
Impacted Files Coverage Δ
...zureIoTHub.Portal/Server/Services/DeviceService.cs 86.15% <55.55%> (+86.15%) ⬆️
...ortal/Server/Controllers/v1.0/DevicesController.cs 66.25% <100.00%> (-2.36%) ⬇️
...Controllers/v1.0/LoRaWANConcentratorsController.cs 73.33% <100.00%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e060d6...73edbb9. Read the comment docs.

@kbeaugrand kbeaugrand enabled auto-merge (squash) February 15, 2022 14:46
@kbeaugrand kbeaugrand disabled auto-merge February 15, 2022 14:53
@kbeaugrand kbeaugrand merged commit 49d60b3 into main Feb 15, 2022
@kbeaugrand kbeaugrand deleted the feature/243_filter_dev_ces_at_iothub_level branch February 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant