Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display DeviceID when the device has no Name #287

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Feb 21, 2022

  • Display DeviceID when the device has no Name
  • Also allow to search on DeviceId or DeviceName in the Search Panel

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

+ Allow to search on DeviceId or DeviceName
@audserraCGI audserraCGI requested a review from a team as a code owner February 21, 2022 10:02
@audserraCGI audserraCGI linked an issue Feb 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #287 (7b61de7) into main (71883b6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   39.63%   39.62%   -0.02%     
==========================================
  Files          93       93              
  Lines        2750     2751       +1     
==========================================
  Hits         1090     1090              
- Misses       1660     1661       +1     
Impacted Files Coverage Δ
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71883b6...7b61de7. Read the comment docs.

@kbeaugrand kbeaugrand merged commit e4daeb0 into main Feb 21, 2022
@kbeaugrand kbeaugrand deleted the fix_271_no_device_name branch February 21, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No device name for devices created prior to release 1.0.1
2 participants