Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

288 Fix IoT Edge configuration page #289

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Feb 21, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

IConfigService renamed to be similar to IDeviceService
@audserraCGI audserraCGI requested a review from a team as a code owner February 21, 2022 12:39
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #289 (5c672ae) into main (7cc732a) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   39.62%   39.62%           
=======================================
  Files          93       93           
  Lines        2751     2751           
=======================================
  Hits         1090     1090           
  Misses       1661     1661           
Impacted Files Coverage Δ
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 84.21% <0.00%> (ø)
src/AzureIoTHub.Portal/Server/Startup.cs 0.00% <0.00%> (ø)
...r/Controllers/v1.0/EdgeConfigurationsController.cs 96.22% <100.00%> (ø)
...zureIoTHub.Portal/Server/Services/ConfigService.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc732a...5c672ae. Read the comment docs.

@audserraCGI audserraCGI merged commit e16653a into main Feb 21, 2022
@audserraCGI audserraCGI deleted the 288_fix_configurations branch February 21, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants