Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added application setting screen to set device tags #303

Merged
merged 42 commits into from
Feb 25, 2022
Merged

Added application setting screen to set device tags #303

merged 42 commits into from
Feb 25, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Feb 23, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner February 23, 2022 10:53
@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #303 (edba746) into main (e9d5494) will increase coverage by 0.53%.
The diff coverage is 53.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   41.19%   41.73%   +0.53%     
==========================================
  Files          95       99       +4     
  Lines        2784     2897     +113     
==========================================
+ Hits         1147     1209      +62     
- Misses       1637     1688      +51
Impacted Files Coverage Δ
....Portal/Client/Pages/Settings/DeviceTagsPage.razor 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 0.00% <ø> (ø)
...THub.Portal/Server/Factories/TableClientFactory.cs 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Server/Startup.cs 0.00% <0.00%> (ø)
...er/Controllers/v1.0/DeviceTagSettingsController.cs 100.00% <100.00%> (ø)
...ureIoTHub.Portal/Server/Mappers/DeviceTagMapper.cs 100.00% <100.00%> (ø)
...THub.Portal/Shared/Models/v1.0/Device/DeviceTag.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8028a...edba746. Read the comment docs.

@kbeaugrand kbeaugrand linked an issue Feb 23, 2022 that may be closed by this pull request
Task: Create application setting screen #235
Closed
kbeaugrand
kbeaugrand requested changes Feb 24, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new Attributes for controllers (for Open API documentation purpose)

src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettingsController.cs Show resolved Hide resolved
audserraCGI and others added 19 commits February 25, 2022 09:31
@audserraCGI @kbeaugrand
Update src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettin…
430fb0f 
…gsController.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>
@audserraCGI
Merge branch 'main' into 235_application_setting_screen
5ef5646
@audserraCGI
Add DeviceTag model
6cf6843
@audserraCGI
Add DeviceTags setting page
0afae68
@audserraCGI
Removed unused using directives
3c1621a
@audserraCGI
Added DeviceTagMapper and DeviceTagSettingsController (POST)
d629ce1
@audserraCGI
Unit test on DeviceTagMapper
7bbef14
@audserraCGI
Added unit tests DeviceTagSettingsControllerTests
1fe7b6f
@audserraCGI
Get function added in the DeviceTagSettingsController
15d4072
@audserraCGI
GET & POST tests ok
006e20a
@audserraCGI
Added loading circle and form validation
5633bba
@audserraCGI
Better form validation
f6ae5ac
@audserraCGI
Added regex for tag name
8f98e8c
@audserraCGI
Check duplicate in tag name
d78c381
@audserraCGI @kbeaugrand
Update src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettin…
d7fb260 
…gsController.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>
@audserraCGI @kbeaugrand
Update src/AzureIoTHub.Portal/Client/Pages/Settings/DeviceTagsPage.razor
006f83f 
Co-authored-by: Kevin BEAUGRAND <[email protected]>
@audserraCGI @kbeaugrand
Update src/AzureIoTHub.Portal/Client/Pages/Settings/DeviceTagsPage.razor
d74fbc4 
Co-authored-by: Kevin BEAUGRAND <[email protected]>
@audserraCGI @kbeaugrand
Update src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettin…
eacf9cb 
…gsController.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>
@audserraCGI
Fix conflicts
edba746
@audserraCGI audserraCGI enabled auto-merge (squash) February 25, 2022 09:25
@audserraCGI audserraCGI merged commit 5a5441f into main Feb 25, 2022
@audserraCGI audserraCGI deleted the 235_application_setting_screen branch February 25, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Create application setting screen
2 participants
@audserraCGI @kbeaugrand