Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #326 - Make fields disabled if builtin #335

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 25, 2022

Description

What's new?

  • Remake readonly fields if builtin

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 25, 2022 12:49
@kbeaugrand kbeaugrand linked an issue Feb 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #335 (ed294fc) into main (b1aef0d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files          99       99           
  Lines        2897     2897           
=======================================
  Hits         1209     1209           
  Misses       1688     1688           
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 0.00% <ø> (ø)
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1aef0d...ed294fc. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 3dd00e0 into main Feb 25, 2022
@kbeaugrand kbeaugrand deleted the fix/326_builtin_device_model_is_modifiable branch February 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Builtin device model can be modified
1 participant