Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enrollment groups for device models #346

Merged
merged 9 commits into from
Feb 28, 2022
Merged

Create enrollment groups for device models #346

merged 9 commits into from
Feb 28, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 26, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 26, 2022 12:37
@codecov
Copy link

codecov bot commented Feb 26, 2022 •
edited
Loading

Codecov Report

Merging #346 (a24fdc0) into main (4226454) will increase coverage by 2.96%.
The diff coverage is 65.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   41.89%   44.85%   +2.96%     
==========================================
  Files          99      101       +2     
  Lines        2886     2965      +79     
==========================================
+ Hits         1209     1330     +121     
+ Misses       1677     1635      -42
Impacted Files Coverage Δ
...nt/Pages/Edge_Devices/ConnectionStringDialog.razor 0.00% <0.00%> (ø)
...ient/Pages/Edge_Devices/EdgeDeviceDetailPage.razor 0.00% <0.00%> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Server/Startup.cs 1.98% <0.00%> (+1.98%) ⬆️
...tal/Server/Wrappers/AttestationMechanismWrapper.cs 0.00% <0.00%> (ø)
...erver/Wrappers/ProvisioningServiceClientWrapper.cs 0.00% <0.00%> (ø)
...eIoTHub.Portal/Shared/Models/v1.0/IoTEdgeDevice.cs 100.00% <ø> (+5.55%) ⬆️
...erver/Managers/DeviceProvisioningServiceManager.cs 93.10% <91.42%> (+93.10%) ⬆️
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 85.54% <100.00%> (+0.35%) ⬆️
.../Server/Controllers/v1.0/DeviceModelsController.cs 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4226454...a24fdc0. Read the comment docs.

@kbeaugrand kbeaugrand enabled auto-merge (squash) February 27, 2022 18:07
@kbeaugrand kbeaugrand disabled auto-merge February 27, 2022 22:53
@kbeaugrand kbeaugrand changed the title Fix #317 - Create enrollment group for device models Create enrollmét groups and automatic configuration models Feb 27, 2022
@kbeaugrand kbeaugrand changed the title Create enrollmét groups and automatic configuration models Create enrollment groups and automatic configuration models Feb 27, 2022
@kbeaugrand kbeaugrand changed the title Create enrollment groups and automatic configuration models WIP : Create enrollment groups and automatic configuration models Feb 28, 2022
@kbeaugrand kbeaugrand changed the title WIP : Create enrollment groups and automatic configuration models WIP : Create enrollment groups and automatic configuration for device models Feb 28, 2022
@kbeaugrand kbeaugrand changed the title WIP : Create enrollment groups and automatic configuration for device models Create enrollment groups and automatic configuration for device models Feb 28, 2022
@kbeaugrand kbeaugrand changed the title Create enrollment groups and automatic configuration for device models Create enrollment groups for device models Feb 28, 2022
@kbeaugrand kbeaugrand linked an issue Feb 28, 2022 that may be closed by this pull request
Bug: IoT Edge Connect show bad primary key for the device. #347
Closed
@kbeaugrand kbeaugrand merged commit 8957aff into main Feb 28, 2022
@kbeaugrand kbeaugrand deleted the feature/317_create_enrollment_group_for_models branch February 28, 2022 08:43
@github-actions github-actions bot mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audserraCGI audserraCGI audserraCGI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kbeaugrand @audserraCGI