Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device model changes should create new automatic device configuration #351

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 28, 2022 09:02
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #351 (7294029) into main (250ccab) will increase coverage by 0.55%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   46.10%   46.66%   +0.55%     
==========================================
  Files         101      101              
  Lines        2967     2998      +31     
==========================================
+ Hits         1368     1399      +31     
  Misses       1599     1599              
Impacted Files Coverage Δ
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <ø> (ø)
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 0.00% <ø> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 0.00% <0.00%> (ø)
...zureIoTHub.Portal/Server/Services/DeviceService.cs 86.15% <ø> (ø)
...erver/Wrappers/ProvisioningServiceClientWrapper.cs 0.00% <0.00%> (ø)
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 85.79% <100.00%> (+0.25%) ⬆️
.../Server/Controllers/v1.0/DeviceModelsController.cs 100.00% <100.00%> (ø)
...r/Controllers/v1.0/EdgeConfigurationsController.cs 96.22% <100.00%> (ø)
...erver/Managers/DeviceProvisioningServiceManager.cs 93.10% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250ccab...7294029. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the feature/319_create_automatic_deployment_for_mode_update branch from 6e9874e to 79eb0a1 Compare February 28, 2022 14:18
@kbeaugrand kbeaugrand changed the title WIP: Device model changes should create new automatic device configuration Device model changes should create new automatic device configuration Feb 28, 2022
@kbeaugrand kbeaugrand added this to the S13 milestone Feb 28, 2022
@kbeaugrand kbeaugrand merged commit 9e6eab6 into main Feb 28, 2022
@kbeaugrand kbeaugrand deleted the feature/319_create_automatic_deployment_for_mode_update branch February 28, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

2 participants