Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#333 bug when lora is disabled #353

Merged
merged 11 commits into from
Feb 28, 2022
Merged

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Feb 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 requested a review from a team as a code owner February 28, 2022 13:03
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #353 (6b3f538) into main (8957aff) will increase coverage by 1.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   44.85%   46.10%   +1.25%     
==========================================
  Files         101      101              
  Lines        2965     2967       +2     
==========================================
+ Hits         1330     1368      +38     
+ Misses       1635     1599      -36     
Impacted Files Coverage Δ
...lient/Pages/DeviceModels/DeviceModelListPage.razor 42.85% <100.00%> (+42.85%) ⬆️
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 67.60% <100.00%> (+31.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8957aff...6b3f538. Read the comment docs.

@Sben65 Sben65 merged commit 250ccab into main Feb 28, 2022
@Sben65 Sben65 deleted the issue#333_bug_when_lora_is_disabled branch February 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When LoRa is disabled, Device model and Device details failed to load
2 participants