Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPS connection on device detail page if not lora #357

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 28, 2022 18:22
@kbeaugrand kbeaugrand force-pushed the feature/318_add_dps_connection_credentials_to_device branch from 4f01d87 to 6ebf7b6 Compare February 28, 2022 18:23
@kbeaugrand kbeaugrand linked an issue Feb 28, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #357 (6ebf7b6) into main (de96cc6) will decrease coverage by 0.58%.
The diff coverage is 2.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   46.73%   46.14%   -0.59%     
==========================================
  Files         101      102       +1     
  Lines        2998     3038      +40     
==========================================
+ Hits         1401     1402       +1     
- Misses       1597     1636      +39     
Impacted Files Coverage Δ
.../Client/Pages/Devices/ConnectionStringDialog.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...ient/Pages/Edge_Devices/EdgeDeviceDetailPage.razor 0.00% <0.00%> (ø)
...erver/Managers/DeviceProvisioningServiceManager.cs 91.11% <33.33%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de96cc6...6ebf7b6. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 1102df8 into main Feb 28, 2022
@kbeaugrand kbeaugrand deleted the feature/318_add_dps_connection_credentials_to_device branch February 28, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task : Add device connection through DPS
1 participant