Fix #308 - Remove useless pages in table queries #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 46.13% 46.35% +0.22%
==========================================
Files 102 102
Lines 3037 3029 -8
==========================================
+ Hits 1401 1404 +3
+ Misses 1636 1625 -11
Continue to review full report at Codecov.
|
Sben65
approved these changes
Mar 4, 2022
audserraCGI
approved these changes
Mar 4, 2022
audserraCGI
added a commit
that referenced
this pull request
Mar 4, 2022
* Fix Namespace issue * Added DeviceTagService + Custom tags on CreateDevicePage * Customised tag on DeviceDetailPage * List<DeviceTag> changed to List<string> in CreateDeviceDetails() * Fix DeviceMapper Tests to work with new DeviceDetails model * Fix DevicesControllerTests with new DeviceDetails model * Added DeviceTagService Test * Added DEviceTagsSettingsController test * Fix Namespace issue * Added DeviceTagService + Custom tags on CreateDevicePage * Customised tag on DeviceDetailPage * List<DeviceTag> changed to List<string> in CreateDeviceDetails() * Fix DeviceMapper Tests to work with new DeviceDetails model * Fix DevicesControllerTests with new DeviceDetails model * Added DeviceTagService Test * Added DEviceTagsSettingsController test * Fixed typo when merging * Fix code scanning errors * Small fix * Added form validation on front side * Added form validation on Edit page * Fix comments * Fix #362 - Update API version + Better treat errors (#378) * Fix #308 - Remove useless pages in table queries (#379) * Fix #308 - Remove useless pages in table queries * Add some unit test to increase code coverage * Fix tests and clear code * Fix change in pagination conflict * Fix Namespace issue * Added DeviceTagService + Custom tags on CreateDevicePage * Customised tag on DeviceDetailPage * List<DeviceTag> changed to List<string> in CreateDeviceDetails() * Fix DeviceMapper Tests to work with new DeviceDetails model * Fix DevicesControllerTests with new DeviceDetails model * Added DeviceTagService Test * Added DEviceTagsSettingsController test * Added DeviceTagService + Custom tags on CreateDevicePage * List<DeviceTag> changed to List<string> in CreateDeviceDetails() * Added DeviceTagService Test * Added DEviceTagsSettingsController test * Fixed typo when merging * Fix code scanning errors * Small fix * Added form validation on front side * Added form validation on Edit page * Fix comments * Fix tests and clear code * Fix change in pagination conflict * Update src/AzureIoTHub.Portal/Server/Controllers/v1.0/DeviceTagSettingsController.cs Co-authored-by: Kevin BEAUGRAND <[email protected]> Co-authored-by: Kevin BEAUGRAND <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?