Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device model properties support #385

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 7, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 7, 2022 07:14
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #385 (bf055b7) into main (da30f26) will increase coverage by 6.08%.
The diff coverage is 84.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   49.70%   55.79%   +6.08%     
==========================================
  Files         101      107       +6     
  Lines        2929     3061     +132     
==========================================
+ Hits         1456     1708     +252     
+ Misses       1473     1353     -120     
Impacted Files Coverage Δ
...THub.Portal/Server/Factories/TableClientFactory.cs 0.00% <0.00%> (ø)
...Hub.Portal/Server/Mappers/DevicePropertyProfile.cs 0.00% <0.00%> (ø)
...THub.Portal/Server/Entities/DeviceModelProperty.cs 25.00% <25.00%> (ø)
...c/AzureIoTHub.Portal/Server/Entities/EntityBase.cs 50.00% <50.00%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 61.78% <91.66%> (+61.78%) ⬆️
...ontrollers/v1.0/DeviceModelPropertiesController.cs 93.22% <93.22%> (ø)
...ortal/Client/Validators/DevicePropertyValidator.cs 94.44% <94.44%> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 58.20% <100.00%> (+58.20%) ⬆️
...IoTHub.Portal/Shared/Models/v1.0/DeviceProperty.cs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7a2c2...bf055b7. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the feature/implement_device_model_properties branch from 001f87a to b076819 Compare March 7, 2022 07:23
@kbeaugrand kbeaugrand linked an issue Mar 7, 2022 that may be closed by this pull request
@kbeaugrand kbeaugrand changed the title Add device model properties support WIP: Add device model properties support Mar 7, 2022
@kbeaugrand kbeaugrand force-pushed the feature/implement_device_model_properties branch 3 times, most recently from 9128068 to 1d55042 Compare March 7, 2022 17:43
@kbeaugrand kbeaugrand force-pushed the feature/implement_device_model_properties branch 2 times, most recently from c6c60f4 to a743d1c Compare March 8, 2022 16:23
@kbeaugrand kbeaugrand changed the title WIP: Add device model properties support Add device model properties support Mar 8, 2022
@kbeaugrand kbeaugrand force-pushed the feature/implement_device_model_properties branch from a743d1c to bf055b7 Compare March 8, 2022 16:43
@kbeaugrand kbeaugrand enabled auto-merge (squash) March 8, 2022 16:48
@kbeaugrand kbeaugrand merged commit a417c9f into main Mar 8, 2022
@kbeaugrand kbeaugrand deleted the feature/implement_device_model_properties branch March 8, 2022 16:51
@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add Device model properties support
2 participants