Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added form validation when creating a new device model #392

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 8, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 8, 2022 09:56
@audserraCGI audserraCGI linked an issue Mar 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #392 (665d4ba) into main (a693b52) will decrease coverage by 0.58%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   50.29%   49.70%   -0.59%     
==========================================
  Files         101      101              
  Lines        2895     2929      +34     
==========================================
  Hits         1456     1456              
- Misses       1439     1473      +34     
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 0.00% <0.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 48.57% <ø> (ø)
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a693b52...665d4ba. Read the comment docs.

@kbeaugrand kbeaugrand merged commit da30f26 into main Mar 8, 2022
@kbeaugrand kbeaugrand deleted the 325_form_validation_device_model branch March 8, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Form validation issue when creating a new device model
2 participants