Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make device tags searchable in the search panel on DevicesListPage #397

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Make device tags searchable in the search panel on DevicesListPage #397

merged 4 commits into from
Mar 9, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 9, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 9, 2022 09:45
@codecov
Copy link

codecov bot commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #397 (f399f90) into main (da30f26) will increase coverage by 5.94%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   49.70%   55.65%   +5.94%     
==========================================
  Files         101      107       +6     
  Lines        2929     3110     +181     
==========================================
+ Hits         1456     1731     +275     
+ Misses       1473     1379      -94
Impacted Files Coverage Δ
...THub.Portal/Server/Factories/TableClientFactory.cs 0.00% <0.00%> (ø)
...Hub.Portal/Server/Mappers/DevicePropertyProfile.cs 0.00% <0.00%> (ø)
...eIoTHub.Portal/Server/Services/DeviceTagService.cs 84.90% <0.00%> (-15.10%) ⬇️
...THub.Portal/Server/Entities/DeviceModelProperty.cs 25.00% <25.00%> (ø)
...reIoTHub.Portal/Server/Mappers/LoRaDeviceMapper.cs 90.90% <40.00%> (-9.10%) ⬇️
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 61.95% <45.45%> (-5.65%) ⬇️
...c/AzureIoTHub.Portal/Server/Entities/EntityBase.cs 50.00% <50.00%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 61.78% <91.66%> (+61.78%) ⬆️
...ontrollers/v1.0/DeviceModelPropertiesController.cs 93.22% <93.22%> (ø)
...ortal/Client/Validators/DevicePropertyValidator.cs 94.44% <94.44%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a547f...f399f90. Read the comment docs.

@audserraCGI audserraCGI changed the title WIP : Make device tags searchable in the search panel on DevicesListPage Make device tags searchable in the search panel on DevicesListPage Mar 9, 2022
@audserraCGI audserraCGI merged commit 5b80e6f into main Mar 9, 2022
@audserraCGI audserraCGI deleted the 237_make_device_tags_searchable branch March 9, 2022 13:39
@github-actions github-actions bot mentioned this pull request Mar 9, 2022
Merged
Sben65 added a commit that referenced this pull request Mar 9, 2022
@Sben65 @audserraCGI
@dependabot @kbeaugrand
WIP : Issue#191 manage lora device properties (#400)
cf1e0c6 
* Abp and OTAA setting.

* add and edit lora properties

* manage lora properties

* update test

* Make device tags searchable in the search panel on DevicesListPage (#397)

* Added searchable tags to DeviceListItem object

* Added tags field in the search panel

* Fix unit tests

* Fix code scanning errors

* Bump Microsoft.Graph from 4.19.0 to 4.20.0 in /src (#403)

Bumps [Microsoft.Graph](https://github.com/microsoftgraph/msgraph-sdk-dotnet) from 4.19.0 to 4.20.0.
- [Release notes](https://github.com/microsoftgraph/msgraph-sdk-dotnet/releases)
- [Commits](microsoftgraph/msgraph-sdk-dotnet@4.19.0...4.20.0)

---
updated-dependencies:
- dependency-name: Microsoft.Graph
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.Extensions.Http.Polly from 6.0.2 to 6.0.3 in /src (#404)

Bumps [Microsoft.Extensions.Http.Polly](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Http.Polly
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Authentication.JwtBearer in /src (#405)

Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Components.WebAssembly.Authentication in /src (#406)

Bumps [Microsoft.AspNetCore.Components.WebAssembly.Authentication](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Components.WebAssembly.Authentication
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Authentication.OpenIdConnect in /src (#407)

Bumps [Microsoft.AspNetCore.Authentication.OpenIdConnect](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Authentication.OpenIdConnect
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Microsoft.AspNetCore.Components.WebAssembly.Server in /src (#409)

Bumps [Microsoft.AspNetCore.Components.WebAssembly.Server](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Components.WebAssembly.Server
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Components.WebAssembly in /src (#410)

Bumps [Microsoft.AspNetCore.Components.WebAssembly](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Components.WebAssembly
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Components.WebAssembly.DevServer in /src (#411)

Bumps [Microsoft.AspNetCore.Components.WebAssembly.DevServer](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Components.WebAssembly.DevServer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* Bump Microsoft.AspNetCore.Mvc.Testing from 6.0.2 to 6.0.3 in /src (#412)

Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>

* minor update

* Abp and OTAA setting.

* add and edit lora properties

* manage lora properties

* update test

* minor update

* add loradeviceMapperTests

Co-authored-by: Audrey SERRA <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin BEAUGRAND <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audserraCGI @kbeaugrand