Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lorawan device model custom propertis support #417

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 9, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 9, 2022 20:30
@kbeaugrand kbeaugrand force-pushed the fix/unaccessible_device_model_if_lorawan branch from 2474969 to 3cbc0c1 Compare March 9, 2022 20:41
@kbeaugrand kbeaugrand force-pushed the fix/unaccessible_device_model_if_lorawan branch from 3cbc0c1 to 96a56c3 Compare March 9, 2022 21:14
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #417 (96a56c3) into main (8c62f6d) will increase coverage by 0.23%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   57.14%   57.37%   +0.23%     
==========================================
  Files         109      111       +2     
  Lines        3269     3287      +18     
==========================================
+ Hits         1868     1886      +18     
  Misses       1401     1401              
Impacted Files Coverage Δ
.../Server/Controllers/v1.0/DeviceModelsController.cs 100.00% <ø> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 0.00% <ø> (ø)
...ollers/v1.0/DeviceModelPropertiesControllerBase.cs 93.22% <93.22%> (ø)
...ontrollers/v1.0/DeviceModelPropertiesController.cs 100.00% <100.00%> (+6.77%) ⬆️
...trollers/v1.0/LoRaWAN/LoRaWANCommandsController.cs 94.20% <100.00%> (ø)
.../LoRaWAN/LoRaWANDeviceModelPropertiesController.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c62f6d...96a56c3. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 1200105 into main Mar 9, 2022
@kbeaugrand kbeaugrand deleted the fix/unaccessible_device_model_if_lorawan branch March 9, 2022 21:16
@github-actions github-actions bot mentioned this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant