Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Cannot send a LoRaWAN command with the same name on several models #433

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 11, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 11, 2022 10:07
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #433 (26bcb29) into main (fa76786) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files         111      111           
  Lines        3294     3294           
=======================================
  Hits         1894     1894           
  Misses       1400     1400           
Impacted Files Coverage Δ
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)
...rtal/Server/Managers/DeviceModelCommandsManager.cs 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa76786...26bcb29. Read the comment docs.

@audserraCGI audserraCGI enabled auto-merge (squash) March 11, 2022 10:16
@audserraCGI audserraCGI merged commit 16337df into main Mar 11, 2022
@audserraCGI audserraCGI deleted the 390_issue_when_sending_commands_with_same_name branch March 11, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot send a LoRaWAN command with the same name on several models
2 participants